Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Git Info Check Regression #190

Conversation

thafryer
Copy link
Member

@thafryer thafryer commented Feb 27, 2024

This PR ensures that the Git error messaging does not show until a project ID has been set. We also migrated from Jest to VItest.

TO QA

  1. Run npx storybook@next init in an empty directory to generate a new project.
  2. Confirm that error messages for Git show early when it should not.
  3. Install this canary.
  4. Confirm Git messages do not show until you click "enable" and link a project.
📦 Published PR as canary version: 1.1.13--canary.190.0b5c9a5.0

✨ Test out this PR locally via:

npm install @chromatic-com/storybook@1.1.13--canary.190.0b5c9a5.0
# or 
yarn add @chromatic-com/storybook@1.1.13--canary.190.0b5c9a5.0

@thafryer thafryer force-pushed the jarel/ap-4293-vta-git-not-found-message-should-not-show-until-addon-is-set branch 4 times, most recently from bb370ab to 5caebd4 Compare February 27, 2024 06:35
@thafryer thafryer force-pushed the jarel/ap-4293-vta-git-not-found-message-should-not-show-until-addon-is-set branch from 5caebd4 to 0b5c9a5 Compare February 27, 2024 15:28
Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

▼👁️👍🏻

@thafryer thafryer merged commit 3d0af54 into main Feb 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants